Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the these anonymous constants
Parent::<1>::Mapping::<{ 2 * 5 }>::{constant#0}, substs:[1, {2 * 5}](1 parent subst, 1 own subst)<impl at dump_mir_2.rs:5:1: 5:37>::Mapping::{constant#0}, substs:[](0 parent substs, 0 own substs)the branch added in this PR & labeled
// Inherent projectionsis not taken (which is good) sinceHowever, when the first parent subst is a type, we incorrectly assume it to be the self type and
the branch is taken which is bad.
For example:
Here (via
-Zdump-mir=all) we incorrectly print the anonymous constant corresp. toA + I(I guess) inside ofStore<{…}>assigned toMappingas<()>::Mapping::<3, { 2 * 5 }>::{constant#0}instead ofParent::<(), 3>::Mapping::<{ 2 * 5 }>::{constant#0}.Conclusion: Don't use
print_def_pathfor inherent projections!