Skip to content

ci: pre-commit-checks bump, link checking, build hardening - #557

Merged
fredclausen merged 2 commits into
mainfrom
ci-hardening
Nov 15, 2026
Merged

fredclausen merged 2 commits into
mainfrom
ci-hardening

Conversation

@fredclausen

@fredclausen fredclausen commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Part of the SDR-E / fredsystems CI hardening rollout.

  • ci(lint): expose GITHUB_TOKEN to the pre-commit run
  • chore(flake/precommit-base): b2f45bbb -> 2893bcf2

Link fixes are intentionally not included yet: the new lychee link check's CI results are being compared against local runs first, so a red link check here is expected and will be addressed in a follow-up commit on this PR.

Summary by CodeRabbit

  • Chores
    • Automated checks now use GitHub authentication when validating links to GitHub. This is an internal workflow change and does not alter any user-facing features or app behavior.

The lychee link check uses it to check github.com links through the
API instead of being rate limited.
Brings in actionlint (workflow linting), the lychee markdown link check,
and the latest shared hook toolchain.
Copilot AI balanced review requested due to automatic review settings November 15, 2026 16:39
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The lint workflow now provides the GitHub token to the pre-commit command. Comments state that lychee uses it for github.com link checks.

Changes: Lint workflow

Layer / File(s) Summary
Pre-commit token configuration
.github/workflows/lint.yaml
The pre-commit step sets GITHUB_TOKEN to ${{ github.token }}. Comments describe its use by lychee for github.com links.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to 2e213

This change gives the lint workflow's link checker a GitHub token so it avoids rate limits. It affects only CI and is easy to revert. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the three main themes of the PR: a pre-commit-checks toolchain bump, link checking, and build hardening. The raw summary shows only a GITHUB_TOKEN addition to the flake pre-commit step…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the three main themes of the PR: a pre-commit-checks toolchain bump, link checking, and build hardening. The raw summary shows only a GITHUB_TOKEN addition to the flake pre-commit step in lint.yaml, which supports the link checking part. The bump and hardening parts are supported by the objectives and commit messages, not by the file summary. The title is partially related to the changeset: it is accurate but broad, and it lists several items rather than one main change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 58db332b-56f5-419a-aa02-ef5f1dd43d23
Commits

Reviewing files that changed from the base of the PR and between 90255d5 and 2e21313.

Files ignored due to path filters: 1

  • flake.lock is excluded by !**/*.lock
Files selected for processing: 1

  • .github/workflows/lint.yaml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

A failed GitHub MCP request prevented inspection of the upstream pre-commit-checks revision, leaving its link-check/build-hardening changes and planned CI-versus-local comparison requiring human review.

No open issues 🎉

What changed in this PR

Updates the pre-commit tooling and lint workflow as part of the SDR-E / fredsystems CI hardening rollout. Link fixes remain intentionally deferred while CI and local lychee results are compared.

Changes:

  • Bumps FredSystems/pre-commit-checks from b2f45bbb to 2893bcf2.
  • Exposes GITHUB_TOKEN to pre-commit so lychee can authenticate GitHub API requests.
File Description
flake.lock Updates the pre-commit-checks revision and lock metadata.
.github/​workflows/​lint.yaml Passes the GitHub token to the pre-commit step.

Review effort: Balanced

@fredclausen
fredclausen merged commit d02e21e into main Nov 15, 2026
3 checks passed
@fredclausen
fredclausen deleted the ci-hardening branch November 15, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants