You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(base): run actionlint on GitHub workflows - #88
Adds an actionlint hook to the base hook set, next to check-github-workflows.
Why
check-github-workflows only validates workflows against the JSON schema. actionlint adds the semantic layer:
expression and context typos
unknown runner labels
shellcheck on every run: block (the nixpkgs package is wrapped with shellcheck, verified with a bare PATH)
Tracked in fredsystems/nixos Plan 03, cleanup entry 3.13.
Rollout
This is enabled for every consumer (44 repos), by decision: enable now, fix each repo as its base bump fails. An inventory of actionlint findings across all 44, taken today:
17 repos have findings, 158 in total. The big ones:
sdr-enthusiasts/common-github-workflows: 102
docker-acarshub: 14
docker-tar1090: 8
freminal: 6
the rest: 1–3 each
About 20 are runner-label findings. Those are custom self-hosted labels that need a .github/actionlint.yaml (self-hosted-runner.labels) in that repo, not workflow changes.
Verification
nix flake check here passes.
In fredsystems/nixos, with --override-input precommit-base pointing at this branch:
On #2820's branch (findings fixed), pre-commit-check builds with actionlint Passed.
On main (unfixed), actionlint Failed on exactly the SC2086 findings #2820 fixes.
Summary by CodeRabbit
Chores
Added automated checks for GitHub Actions workflow files.
check-github-workflows only validates workflows against the JSON schema.
actionlint adds the semantic layer: expression and context typos, unknown
runner labels, and shellcheck on every run: block (the nixpkgs package is
wrapped with shellcheck). Enabled for every consumer; repos with custom
self-hosted runner labels declare them in .github/actionlint.yaml.
The new hook runs for every consumer that updates its base input. The PR reports existing findings in 17 repositories, so those consumers will need workflow fixes or an actionlint config for custom runner labels when they update. This is an intended tradeoff and is bounded, so the change is mergeable with awareness from the maintainers.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: adding an actionlint check for GitHub workflows.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
The reason will be displayed to describe this comment to others. Learn more.
Additional comments: 1
checks/base.nix-234-234: 1
234-234: Major · Stability & Availability · Heavy lift
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Stage the default rollout until consumers are ready.
The PR reports findings in 17 consumer repositories. It also reports that fredsystems/nixos main fails this check. Enabling the hook by default can therefore block existing consumer checks immediately. Coordinate the consumer fixes before activation, or make the hook opt-in during rollout.
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Team
Run ID: 10c3a103-4dc3-4b47-a7ab-fe7617207434
Commits
Reviewing files that changed from the base of the PR and between e9607c9 and 815ff39.
Files selected for processing: 1
checks/base.nix
Included review availability: This review used your included allowance. 6 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
actionlinthook to the base hook set, next tocheck-github-workflows.Why
check-github-workflowsonly validates workflows against the JSON schema. actionlint adds the semantic layer:run:block (the nixpkgs package is wrapped with shellcheck, verified with a bare PATH)Tracked in fredsystems/nixos Plan 03, cleanup entry 3.13.
Rollout
This is enabled for every consumer (44 repos), by decision: enable now, fix each repo as its base bump fails. An inventory of actionlint findings across all 44, taken today:
runner-labelfindings. Those are custom self-hosted labels that need a.github/actionlint.yaml(self-hosted-runner.labels) in that repo, not workflow changes.Verification
nix flake checkhere passes.--override-input precommit-basepointing at this branch:pre-commit-checkbuilds with actionlint Passed.main(unfixed), actionlint Failed on exactly the SC2086 findings #2820 fixes.Summary by CodeRabbit