Skip to content

chore: gate CodeRabbit reviews behind readiness - #1848

Open
juanpflores wants to merge 2 commits into
frostney:mainfrom
juanpflores:codex/limit-review-triggering
Open

juanpflores wants to merge 2 commits into
frostney:mainfrom
juanpflores:codex/limit-review-triggering

Conversation

@juanpflores

@juanpflores juanpflores commented Oct 21, 2026 •

Copy link
Copy Markdown

Summary

  • extend the repository TypeScript CodeRabbit configuration with deliberate review controls
  • preserve inherited central settings and dynamic exclusion of vendored Agent Skills
  • review only PRs labeled review-ready, disable automatic incremental follow-ups, and skip github-actions[bot] PRs

Why

This repository opens many small and stacked PRs. The inherited configuration reviews every base branch, while default incremental reviews can spend an included review for every eligible push. In a recent 28-hour period, CodeRabbit posted 81 comments across 40 PRs, including 26 rate-limit notices and 33 notices reporting the reduced 1-review-per-hour allowance.

Making review opt-in keeps CodeRabbit available for coherent, review-ready changes rather than spending allowance on intermediate stack layers, WIP updates, and routine automation. After merging, create the review-ready GitHub label. Authors can request a later focused pass with @coderabbitai review once they push additional changes.

Verification

  • inspected the TypeScript configuration merge to retain central inheritance and vendored-skill filtering
  • ran git diff --check

@vercel

vercel Bot commented Oct 21, 2026

Copy link
Copy Markdown

@juanpflores is attempting to deploy a commit to the Johannes Stein's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository TS config (base), Central YAML (inherited), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b1e02082-719d-4997-898f-7c4dafb131de
📥 Commits

Reviewing files that changed from the base of the PR and between f60c5d9 and 5064c0d.

📒 Files selected for processing: 1
  • .coderabbit.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The CodeRabbit TypeScript configuration now preserves inherited settings, applies the excluded-skill review scope to the root and reviews settings, and defines automatic-review conditions.

Changes: CodeRabbit configuration

Layer / File(s) Summary
Review scope and automatic-review policy
.coderabbit.config.ts
The configuration defines and spreads the shared excluded-skill review scope into the root and reviews settings. Automatic reviews are disabled by default and enabled by the review-ready label. Incremental reviews are disabled, and GitHub Actions bot reviews are ignored.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: frostney

Merge Risk: ⚪ Minimal · up to 5064c

No actionable merge-blocking risk remains in the reviewed configuration change.

Architecture risk: 🔵 Low · up to 5064c

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .coderabbit.config.ts: Updated the configuration comments to describe inherited central/web settings, vendored-skill exclusions, and deliberate review points.
  • observed — Modified behavior in .coderabbit.config.ts: Expanded the local type assertion for excludeVendoredSkills from a generic object return to a contract containing inheritance and nested review path_filters settings.
  • observed — Modified behavior in .coderabbit.config.ts: Stored the excluded-skill scope in reviewScope, spread it into the root configuration and reviews configuration, and added automatic-review settings: disabled by default, triggered by review-ready, with incremental reviews disabled and GitHub Actions bot reviews ignored.
Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: requiring readiness before CodeRabbit reviews run.
Description check Passed The description includes the required Summary section, explains the implementation constraints and rationale, and documents verification steps. It provides sufficient context for the change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@juanpflores juanpflores reopened this Oct 21, 2026
@juanpflores

Copy link
Copy Markdown
Author

Updated this PR to use .coderabbit.config.ts rather than YAML.

The TypeScript config keeps the existing dynamic skills-lock.json-based exclusion of vendored Agent Skills, while adding the same deliberate-review controls: review only review-ready PRs, do not automatically re-review each push, and skip github-actions[bot] PRs. This avoids freezing the current vendored-skill list in a static YAML file.

Comment thread .coderabbit.config.ts
auto_review: {
// This repository opens many small and stacked PRs. Spend a review only
// when the author marks a coherent change ready for feedback.
enabled: false,

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frostney this is the most abrupt change. Would recommend checking this out before approving. You might be ok already with the incremental reviews being stopped until requested

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant