Skip to content

Add custom lint rules #66

Open
Open
Add custom lint rules#66
Labels
Priority: LowType: Enhancement

Description

@matejsemancik
matejsemancik
opened on Oct 15, 2019

Would be nice to have custom lint rules for mvvm module (eg. wrong event naming) and interactors module (eg. warning that you forgot to use init method, or warning that you are passing Pair as execute argument in future). Any opinions on this?

I already have implemented MVVM event naming rule, and need ideas for more, if that makes sense to you.

Activity

  1. matejsemancik
    added
    enhancement
    Hacktoberfest
    on Oct 15, 2019

  2. skywall commented on Nov 20, 2019

    @skywall
    skywall
    on Nov 20, 2019
    Contributor

    Prohibit multiple usage of same lambda in InteractorConfig:

    interactor.execute(Unit) {
    onError {}
    onError {}
}

    Check order of lambdas in InteractorConfig:

    OK
interactor.execute(Unit) {
    onSuccess {}
    onError {}
}

BAD
interactor.execute(Unit) {
    onError {}
    onSuccess {}
}
  3. skywall
    added
    Priority: Low
    Type: Enhancement
    and removed
    enhancement
    Hacktoberfest
    on May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority: LowType: Enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions