Repository navigation
Conversation
Member
|
Awesome! 👍 Could you also add a test for it ? |
jbelien
changed the title
|
This is not consistent with the GoogleMaps provider at least for Dutch addresses. The town of Zaandam is in the municipality of Zaanstad. Google maps returns Zaandam as locality and Zaanstad as administrative area level 2. This would return Zaanstad as locality and nothing as administrative area level 2 (we don't have counties). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Municipality was not in the array of 'locality' fields, see #1155.
Order matters, not sure what position in the array this should have.