Repository navigation
fix(core): allow project arrays in framework build options #25534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7ff0cfe
b1473fe
fed9b2c
344c713
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ describe('Sentry React-Router build-time options type', () => { | |
| const completeOptions: SentryReactRouterBuildOptions = { | ||
| // --- BuildTimeOptionsBase options --- | ||
| org: 'test-org', | ||
| project: 'test-project', | ||
| project: ['test-project', 'other-project'], | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. q/l: Could we keep at least one test with one project?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. jep good idea
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah just checked and actually most unit tests still use a single project config so should be sufficiently covered |
||
| authToken: 'test-auth-token', | ||
| sentryUrl: 'https://sentry.io', | ||
| headers: { Authorization: ' Bearer test-auth-token' }, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: Shouldn't we rather implement this in the Sentry CLI? Might be useful that the logic is there too. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can look into it. we could streamline the implementation here a bit but also not too bad as it is imo