Repository navigation
fix(android): Apply screenshot masking options to error and feedback screenshots - #6930
Merged
Merged
Conversation
…screenshots Use sentry-java's takeMaskedScreenshot for screenshots captured from JS, default maskAllText/maskAllImages to true as documented, and honor Sentry.Mask/Sentry.Unmask when the replay module is available. Fixes #6900 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
…ror-screenshots # Conflicts: # CHANGELOG.md
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 551de0b. Configure here.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
antonis
marked this pull request as ready for review
October 22, 2026 10:46
📲 Install BuildsAndroid
|
antonis
marked this pull request as draft
October 22, 2026 11:10
antonis
commented
Oct 27, 2026
antonis
commented
Oct 27, 2026
antonis
left a comment
antonis
left a comment
Contributor
Author
There was a problem hiding this comment.
Unblocked with the 8.62.0 bump that included getsentry/sentry-java#6356
antonis
marked this pull request as ready for review
October 27, 2026 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR:
ScreenshotUtils.takeMaskedScreenshot(sentry-java 8.61.1, feat(android): Add masked screenshot capture for Hybrid SDKs sentry-java#6281), which masks them the same way native error screenshots are masked. If the native options aren't available, no screenshot is taken.screenshot.maskAllText/maskAllImagestotrueon Android, as documented. The native Android SDK leaves them off until its next major, and RN only forwarded them when set.maskAllImagesis on, like Session Replay.<Sentry.Mask>/<Sentry.Unmask>in screenshots whensentry-android-replayis available.💡 Motivation and Context
Fixes #6900
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps