Repository navigation
ref(performance): Remove TransactionArc type alias - #1327
Open
szokeasaurusrex wants to merge 1 commit into
Open
szokeasaurusrex wants to merge 1 commit into
szokeasaurusrex wants to merge 1 commit into
Conversation
Get rid of the `TransactionArc` type alias, and use the `Transaction` type directly, instead. This allows us to use the methods that `Transaction` provides anywhere we were previously just storing the inner `TransactionArc` directly. As `Transaction` is basically just a new type wrapper around `Arc<Mutex<TransactionInner>>` (which `TransactionArc` was previously defined as), there is little benefit to use `TransactionArc` rather than `Transaction`. Overall, this should slighlty simplify the code.
alexander-alderman-webb
approved these changes
Sep 23, 2026
giortzisg
approved these changes
Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get rid of the
TransactionArctype alias, and use theTransactiontype directly, instead.This allows us to use the methods that
Transactionprovides anywhere we were previously just storing the innerTransactionArcdirectly. AsTransactionis basically just a new type wrapper aroundArc<Mutex<TransactionInner>>(whichTransactionArcwas previously defined as), there is little benefit to useTransactionArcrather thanTransaction.Overall, this should slighlty simplify the code.