Skip to content

cli: Remove redundant local sampling variables (#20429) - #22264

Merged
pwilkin merged 1 commit into
ggml-org:masterfrom
ezturner:task/cli-variables-cleanup
Apr 23, 2026
Merged

pwilkin merged 1 commit into
ggml-org:masterfrom
ezturner:task/cli-variables-cleanup

Conversation

@ezturner

Copy link
Copy Markdown
Contributor

Overview

This change implements the third requested change in issue 20429. Because defaults.sampling contains the reasoning budget token count and the reasoning budget message, it's not necessary to assign them to struct variables.

Additional information

#20429

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: AI was not used in this contribution.

This change implements the third requested change in issue 20429.
Because defaults.sampling contains the reasoning budget token count and
the reasoning budget message, it's not necessary to assign them to
struct variables.
@ezturner
ezturner requested a review from ngxson as a code owner April 22, 2026 21:09
@ezturner

Copy link
Copy Markdown
Contributor Author

@pwilkin @ggerganov would either of you be able to take a look? I realized I missed this in #22233

@pwilkin
pwilkin merged commit fa0b8a7 into ggml-org:master Apr 23, 2026
47 of 49 checks passed
IntelNav pushed a commit to IntelNav/llama.cpp that referenced this pull request Apr 29, 2026
…-org#22264)

This change implements the third requested change in issue 20429.
Because defaults.sampling contains the reasoning budget token count and
the reasoning budget message, it's not necessary to assign them to
struct variables.
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
…-org#22264)

This change implements the third requested change in issue 20429.
Because defaults.sampling contains the reasoning budget token count and
the reasoning budget message, it's not necessary to assign them to
struct variables.
baramofme pushed a commit to baramofme/llama-cpp-turboquant that referenced this pull request May 23, 2026
…-org#22264)

This change implements the third requested change in issue 20429.
Because defaults.sampling contains the reasoning budget token count and
the reasoning budget message, it's not necessary to assign them to
struct variables.
MrLordCat referenced this pull request in MrLordCat/llama.cpp-rdna-lab Jul 16, 2026
This change implements the third requested change in issue 20429.
Because defaults.sampling contains the reasoning budget token count and
the reasoning budget message, it's not necessary to assign them to
struct variables.
zommiommy pushed a commit to zommiommy/llama.cpp that referenced this pull request Aug 18, 2026
…-org#22264)

This change implements the third requested change in issue 20429.
Because defaults.sampling contains the reasoning budget token count and
the reasoning budget message, it's not necessary to assign them to
struct variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants