Repository navigation
feat(ui-react): MetaCount's cpu and cpu-danger, and the icons ⚛️ Core had that code didn't - #16415
Merged
Merged
Conversation
Five icons drawn on ⚛️ Core's Icons page had no SVG in src/icons: cpu, cpu-danger, fullscreen-enter, fullscreen-exit and repo-lock. Exported from Figma and run through optimize-icons, which regenerated iconNames.ts.
The two types ⚛️ Core already draws: cpu is a process's CPU use while it stays low, in green, and cpu-danger the same use once it runs high, in red with a warning on the chip. Both are in the Kinds story.
|
This pull request changes Lite's CSS. If the change shows on screen, before/after screenshots make it reviewable without checking the branch out — drag them into a comment, or use the |
|
🎩 Your Storybook has been served
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚛️ Core's MetaCount drew two types the component lacked, and its Icons page had five icons with no SVG.
cpu,cpu-danger,fullscreen-enter,fullscreen-exit,repo-lock, exported from Figma and run throughoptimize-iconsMetaCounttakescpu(green) andcpu-danger(red), both in theKindsstory