Repository navigation
fix(cli): make but branch show treat branches as buckets - #16417
Open
Conversation
davidpdrsn
added this pull request to stack #16411
October 20, 2026 13:28
davidpdrsn
marked this pull request as ready for review
October 20, 2026 13:28
github-actions
Bot
added
rust
davidpdrsn
force-pushed
the
david/gb-2122-but-show-branch-shows-commits-on-descendant-branches
branch
from
October 20, 2026 13:33
3e59c48 to
f8faf12
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Merge histories still include commits outside the selected bucket, and missing bases can cause JSON output failures.
2 open issues
What changed in this PR
Updates CLI branch inspection to treat workspace branches as commit buckets rather than full histories back to the target.
Changes:
- Uses bucket bases in both show commands.
- Corrects dependency ordering and commit counts.
- Adds selected-branch, JSON, and empty-bucket tests.
| File | Description |
|---|---|
| crates/but/tests/but/command/branch/show.rs | Adds bucket-scoped output coverage. |
| crates/but/src/command/legacy/show.rs | Uses bucket bases and corrects dependency reporting. |
| crates/but/src/command/legacy/branch/show.rs | Uses workspace bucket bases when listing commits. |
Review effort: Balanced
davidpdrsn
force-pushed
the
david/gb-2122-but-show-branch-shows-commits-on-descendant-branches
branch
from
October 20, 2026 13:56
f8faf12 to
65c4356
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.