Repository navigation
build: don't ignore Gemfile.lock for deterministic builds - #829
Closed
dijonkitchen wants to merge 1 commit into
Closed
dijonkitchen wants to merge 1 commit into
dijonkitchen wants to merge 1 commit into
Conversation
4 tasks done
Contributor
|
This PR seems to make a failed assertion. When GitHub Pages builds a website (not talking about GitHub Actions) it does NOT use the Gemfile.lock to find what versions to build with. It means that GitHub Pages' infrastructure decides which versions of Jekyll/Ruby/... it is running, not you. This PR does not change that behavior of how GitHub Pages infrastructure works. So if this is PR is accepted, then the test suite will run against new versions of Jekyll/Ruby/... rather than the version that production uses. If my understand is correct here, we should NOT merge this PR. |
Contributor
|
RubyGems do not ship with their Gemfile.lock files. The guidance you linked to is for end users. There is no way for an end user to use the Gemfile.lock from a RubyGem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference:
https://bundler.io/rationale.html#checking-your-code-into-version-control
Seems to match what is published: https://pages.github.com/versions/