Repository navigation
Conversation
mfield4
marked this pull request as ready for review
November 7, 2026 00:30
ckungler
previously approved these changes
Nov 9, 2026
ckungler
previously approved these changes
Nov 11, 2026
Group the host-side C library under host/. Include paths stay the same
("transports/..." and "protocol/..."): Bazel strips the host/ prefix
from each library's headers, and Meson adds host/ to the include path.
Installed header locations are unchanged.
Other updates the move needs:
- Bazel labels //transports and //protocol become //host/...
- The Meson subdir and test mock paths follow the move.
- Three headers that included a sibling by bare name now use the full
"protocol/..." path, which they need once headers resolve through
the stripped prefix.
- Test data runfile paths follow the move.
Downstream consumers still depend on the old //protocol, //protocol/test and //transports labels and can't migrate until the move lands. Add alias-only packages at the old locations that forward to //host/... //protocol/test:test_data copies the fixtures into the old package so they stay at protocol/test/*.bin in runfiles; an alias would put them under host/protocol/test/. Nothing in libhoth should depend on these. They will be deleted in a follow-up once downstream consumers have moved to //host/...
ckungler
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group the host-side C library under host/.