Skip to content

Move transports/ and protocol/ under host/ - #324

Merged
mfield4 merged 2 commits into
mainfrom
host-move
Nov 13, 2026
Merged

mfield4 merged 2 commits into
mainfrom
host-move

Conversation

@mfield4

@mfield4 mfield4 commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Group the host-side C library under host/.

  • Preserved top-level include paths
  • Bazel labels //transports and //protocol become //host/...
  • The Meson subdir and test mock paths follow the move.
  • Three headers that included a sibling by bare name now use the full "protocol/..." path, which they need once headers resolve through the stripped prefix.
  • Test data runfile paths follow the move.

@mfield4
mfield4 marked this pull request as ready for review November 7, 2026 00:30
ckungler
ckungler previously approved these changes Nov 9, 2026
ckungler
ckungler previously approved these changes Nov 11, 2026
Group the host-side C library under host/. Include paths stay the same
("transports/..." and "protocol/..."): Bazel strips the host/ prefix
from each library's headers, and Meson adds host/ to the include path.
Installed header locations are unchanged.

Other updates the move needs:
- Bazel labels //transports and //protocol become //host/...
- The Meson subdir and test mock paths follow the move.
- Three headers that included a sibling by bare name now use the full
  "protocol/..." path, which they need once headers resolve through
  the stripped prefix.
- Test data runfile paths follow the move.
Downstream consumers still depend on the old //protocol, //protocol/test
and //transports labels and can't migrate until the move lands. Add
alias-only packages at the old locations that forward to //host/...

//protocol/test:test_data copies the fixtures into the old package so
they stay at protocol/test/*.bin in runfiles; an alias would put them
under host/protocol/test/.

Nothing in libhoth should depend on these. They will be deleted in a
follow-up once downstream consumers have moved to //host/...
@mfield4
mfield4 merged commit 806de75 into main Nov 13, 2026
11 checks passed
@mfield4
mfield4 deleted the host-move branch November 13, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants