Repository navigation
Conversation
Add protocol support (`HOTH_PRV_CMD_HOTH_GET_FLASH_UID`, 0x0063) to query the cached SPI NOR flash JEDEC ID and Unique ID for each configured flash device slot without initiating live SPI bus transactions, and expose it in `htool` via `htool get_flash_uid`.
mfield4
approved these changes
Nov 18, 2026
| if (rlen != sizeof(*response)) { | ||
| return LIBHOTH_ERR_CONSTRUCT(HOTH_CTX_CMD_EXEC, HOTH_HOST_SPACE_LIBHOTH, | ||
| LIBHOTH_ERR_FAIL); | ||
| } |
Collaborator
There was a problem hiding this comment.
libhoth/host/protocol/host_cmd.c
Line 258 in 88215ad
Code duplication nit: If you pass NULL here for rlen, this check is preformed in libhoth_hostcmd_exec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add protocol support (
HOTH_PRV_CMD_HOTH_GET_FLASH_UID, 0x0063) to query the cached SPI NOR flash JEDEC ID and Unique ID for each configured flash device slot without initiating live SPI bus transactions, and expose it inhtoolviahtool get_flash_uid.