wire: do not use global variables for all wire.Value expressions #185

Activity

1. shantuo

   assigned

   zombiezen

   on Jun 3, 2019
2. zombiezen

   added this to the Unplanned milestone on Jun 7, 2019
3. zombiezen

   added

   enhancementNew feature or requestNew feature or request

   on Jun 7, 2019
4. zombiezen commented on Jun 7, 2019

   

   zombiezen

   on Jun 7, 2019

   Contributor

   More actions

   The reason we have the semantics we have now for wire.Value is that we want to be confident that the expression will evaluate to the same value that was expressed at the wire.NewSet's evaluation. This keeps the behavior of wire.Value largely unsurprising, and amenable to usage in a runtime DI version if needed at some point.

   It sounds like the request here is that the generated code in some circumstances (like when using a constant expression, for example) could be more efficient, since the time that the expression is evaluated wouldn't matter. That seems reasonable to me, but I think we can add this feature in a backward-compatible way later.
5. rogpeppe commented on Jun 8, 2019

   

   rogpeppe

   on Jun 8, 2019

   Author

   More actions

   Yes, but it's not just about efficiency. One of the selling points of wire is that the generated is a readable representation of the dependency setup. This is one thing that makes the code less idiomatic/readable
6. zombiezen commented on Jun 11, 2019

   

   zombiezen

   on Jun 11, 2019

   Contributor

   More actions

   Agreed. To be clear: I think this is a good idea, but we don't have bandwidth to fix it right now. Happy to review PRs to fix.
7. zombiezen

   added

   good first issueGood for newcomersGood for newcomers

   on Jun 11, 2019
8. j4ng5y commented on Jun 25, 2019

   

   j4ng5y

   on Jun 25, 2019

   More actions

   I'll take a stab at this.
9. zombiezen

   removed their assignment

   on Jul 9, 2019
10. ProgrammingMuffin commented on Dec 15, 2023

    

    ProgrammingMuffin

    on Dec 15, 2023

    Last edited by ProgrammingMuffin

    More actions

    @zombiezen A few observations here.

    1. Do we need global variables at all, if we provide that value exactly when and where the programmer wanted to provide it.
    2. Do we need backward compatibility, since the generated code is going to overwrite it anyway and wouldn't affect the code unless the programmer is using those generated global values somewhere else. If yes, do we have any ideas on how to make the backward compatibility work?

    Since this issue is still open, I decided to try it out and it works but it's only a local test change (not confident if that's the solution we are looking for),

    Thank you