Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Node crash when agent is concurrently enabled with inspect #356

Closed
Closed
Node crash when agent is concurrently enabled with inspect#356
Assignees
ofrobots
Labels
🚨This issue needs some love.api: clouddebuggerIssues related to the googleapis/cloud-debug-nodejs API.triage meI really want to be triaged.

Description

@ofrobots
ofrobots
opened on Nov 4, 2017
GCLOUD_USE_INSPECTOR=1 node --inspect log.js

Where log.js is a simple express app with this at the top:

const debug = require('@google-cloud/debug-agent').start({
  projectId: 'some project id'
});

Node crashes when DevTools connects.

/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node[32991]: ../src/inspector_agent.cc:346:void node::inspector::NodeInspectorClient::connectFrontend(node::inspector::InspectorSessionDelegate*): Assertion `(channel_) == (nullptr)' failed.
 1: node::Abort() [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 2: node::(anonymous namespace)::DomainEnter(node::Environment*, v8::Local<v8::Object>) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 3: node::inspector::NodeInspectorClient::FatalException(v8::Local<v8::Value>, v8::Local<v8::Message>) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 4: node::inspector::InspectorIo::DispatchMessages() [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 5: node::RunForegroundTask(v8::Task*) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 6: node::NodePlatform::FlushForegroundTasksInternal() [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 7: uv__async_io [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 8: uv__io_poll [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 9: uv_run [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
10: node::Start(v8::Isolate*, node::IsolateData*, int, char const* const*, int, char const* const*) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
11: node::Start(uv_loop_s*, int, char const* const*, int, char const* const*) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
12: node::Start(int, char**) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
13: start [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]

Activity

  1. ofrobots commented on Nov 4, 2017

    @ofrobots
    ofrobots
    on Nov 4, 2017
    ContributorAuthor

    This is with node 8.9.0 with debug agent 2.2.2.

  2. ofrobots commented on Nov 6, 2017

    @ofrobots
    ofrobots
    on Nov 6, 2017
    ContributorAuthor

    I cannot seem to reproduce the crash reliably so far today. D'oh. I was missing the environment variable.

    /cc @eugeneo @ak239.

  3. ofrobots commented on Nov 6, 2017

    @ofrobots
    ofrobots
    on Nov 6, 2017
    ContributorAuthor

    Minimal repro:

    const inspector = require('inspector');
const session = new inspector.Session();
session.connect();

setInterval(() => { console.log('jello')}, 2000);

    Start with node --inspect test.js. Attach devtools.

  4. ofrobots commented on Nov 6, 2017

    @ofrobots
    ofrobots
    on Nov 6, 2017
    ContributorAuthor

    Without devtools:

    // Flags: --inspect=9229
const inspector = require('inspector');
const session = new inspector.Session();
session.connect();

setInterval(() => { console.log('jello')}, 2000);

setTimeout(() => {
  require('child_process').spawn(process.execPath, [
    'inspect',
    'localhost:9229'
  ])
}, 1000);

  5. ofrobots commented on Nov 6, 2017

    @ofrobots
    ofrobots
    on Nov 6, 2017
    ContributorAuthor

    Opened bug upstream: nodejs/node#16852

  6. ofrobots commented on Nov 7, 2017

    @ofrobots
    ofrobots
    on Nov 7, 2017
    ContributorAuthor

    Closing as the bug is upstream.

  7. ofrobots
    closed this as completedon Nov 7, 2017
  8. gcf-label-sync
    added
    api: clouddebuggerIssues related to the googleapis/cloud-debug-nodejs API.
    on Jan 31, 2020
  9. yoshi-automation
    added
    triage meI really want to be triaged.
    🚨This issue needs some love.
    on Apr 6, 2020
  10. JustinBeckwith
    assigned
    ofrobots
    on Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: clouddebuggerIssues related to the googleapis/cloud-debug-nodejs API.triage meI really want to be triaged.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions