Repository navigation
Conversation
Author
|
Could you take a look at this itemlist prefix-comparison fix when you have time? It handles exhausted operands before unpacking while retaining valid None keys and values. The regression cases and local validation limits are recorded in the description; I am not claiming a hosted CI pass. Please let me know if any changes are needed for review. Thanks. |
Author
|
Hi, following up on this itemlist prefix-comparison fix. Would you have time to review it, or is there anything you'd like changed before review? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing itemlists raises
TypeErrorwhen either list is a strict prefix of the other, including empty versus nonempty lists.zip_longestsuppliesNonefor the exhausted iterator, but the loop unpacks it before it can returnFalse.Check for an exhausted operand before unpacking. The iterator yields triples, so real
Nonekeys and values remain valid. The regression covers both operand orders,==and!=, empty lists, shared prefixes, duplicateNoneentries, and unchanged contents. Controls cover equal lists and unequal keys, values, and order.Validation:
Python 2, older Python versions, PyPy, and other operating systems were not run. No existing tests were changed, and no CI configuration or unrelated behavior was changed.