Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 229 229
Lines 17320 17322 +2
Branches 2204 2204
=======================================
+ Hits 15402 15404 +2
Misses 1289 1289
Partials 629 629 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promosed in #1140, here are some type-coverage improvements, most of which involves the
theme.__init__parameters.I added a script in
toolsthat I've used to generate these param annotations. Unfortunately it's not a complete solution, because it required fixing a couple of annotations afterwards, and I also deduped a lot of duplication in the annotations using type aliases.In order to avoid a Pyright error, I had to annotate a param in
_utils/yippie.py(Pyright would otherwise inferpositionasstr, which isn't assignable to theplot_tag_positionliteral).This increases public type coverage (measured with
uvx pyrefly coverage check --public-only plotnine) from 58.84% to 64.95% (+6.11%). See https://jorenham.github.io/typestats/dashboard/report/#plotnine for a fancy type-coverage dashboard.FYI; I'm planning on opening some other type-coverage PRs like this one soon, and I was thinking of doing
themes.themeablenext :)