Skip to content

Driver '76 icon seems to be decoded wrong #16822

Closed

Description

@hrydgard

We're not the only ones who decode it as all black though:

image

ICON0

Activity

  1. unknownbrackets commented on Jan 21, 2023

    @unknownbrackets
    Collaborator

    I tried a quick recompress of the PNG which generated this image (same pixels/RGB values, just adjusted compression):
    driver76b

    Looking at the metadata, the gamma value is pretty different. If I remove the gAMA chunk only, it similarly looks better:
    driver76-gama

    I guess probably we should be ignoring the gAMA chunk here? Its current value is 22727, which is what causes things to be darker.

    -[Unknown]

  2. hrydgard commented on Jan 21, 2023

    @hrydgard
    OwnerAuthor

    Nice, yeah, indeed seems very likely that the PSP simply ignores the gamma block entirely, and thus we should do the same when displaying these. Don't know if there's an option for it for the png reader we use.

  3. hrydgard commented on Jan 25, 2023

    @hrydgard
    OwnerAuthor

    Doesn't look like there's a way to override gamma in the simplified API that we use (png_image_begin_read_from_memory). We'd have to switch to using the absolutely awful full API to access the gamma modification functions..

  4. added this to the Future-Prio milestone on Jan 25, 2023
  5. modified the milestones: Future-Prio, v1.19.0 on Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    User InterfacePPSSPP's own user interface / UX

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions