Repository navigation
Preserve GOAWAY errors (hyperium/hyper#4268) - #1005
Merged
seanmonstar merged 1 commit intoNov 17, 2026
Merged
Conversation
A transport failure can replace an already-received GOAWAY error after all streams have closed or been rejected by the peer. Prefer the remote reason and debug data for read, pending-write flush, and shutdown failures when no active streams remain. Preserve transport errors for active streams and when no nonzero GOAWAY was received. Validated with nine focused regression tests, the crate unit/doc tests, the full integration suite, Clippy, formatting, and controlled reproductions through Hyper. Refs hyperium/hyper#4268.
shuvroroy
marked this pull request as ready for review
November 14, 2026 06:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs hyperium/hyper#4268.
A socket error can replace an already-parsed, nonzero GOAWAY reason after all streams have finished or been rejected. Preserve the remote reason and debug data across read, pending-write flush, and socket shutdown failures when no active streams remain. Keep existing I/O error behavior for active streams, absent GOAWAY frames, and NO_ERROR GOAWAY frames.
This fixes error precedence after GOAWAY is parsed. It cannot recover the code when the connection fails before the frame is parsed; the immediate-close TCP reproduction can still return an I/O error in that case.