Skip to content

http1 options are exposed through client::Builder but not lower-level client::conn::Builder interface #2461

Closed

Description

@acfoltzer

http1_read_buf_exact_size, http1_max_buf_size, and http1_title_case_headers are all configuration methods on hyper::client::Builder, but not hyper::client::conn::Builder. I notice that the methods are present on the latter type but are pub(super) rather than pub.

Currently, I believe users of the conn interface are stuck with the default values of these settings. Are there any reasons not to make these pub with similar docstrings to the higher-level API? I'd be happy to provide a PR if not.

Activity

  1. seanmonstar commented on Mar 11, 2021

    @seanmonstar
    Member

    I believe it is simply an oversight. I'd say more of the builder options also make sense on the conn types (besides pooling, listener config, the obvious).

  2. added
    E-easyEffort: easy. A task that would be a great starting point for a new contributor.
    on Mar 11, 2021
  3. added a commit that references this issue on Aug 3, 2021
    e797fe3
  4. added a commit that references this issue on Aug 4, 2021
    73bff4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-clientArea: client.E-easyEffort: easy. A task that would be a great starting point for a new contributor.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions