Skip to content

Backport Http1 Graceful Shutdown Fix #3306

Closed as not planned
Closed as not planned

Description

@bonedaddy

Overview

#3261 introduced a fix for slow graceful shutdowns, however it is only available in a release candidate version which introduces breaking api changes.

Suggestion

Backport the graceful shutdown fix into v0.14.27 and cut a new release allowing third-party packages like axum to implement the fix.

Activity

  1. added
    C-featureCategory: feature. This is adding a new feature.
    on Sep 8, 2023
  2. added
    B-breaking-changeBlocked: this is an "API breaking change".
    and removed
    C-featureCategory: feature. This is adding a new feature.
    on Nov 21, 2023
  3. seanmonstar commented on Nov 21, 2023

    @seanmonstar
    Member

    This was considered a behavioral breaking change, which is why it was only included in 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    B-breaking-changeBlocked: this is an "API breaking change".V-0.14.x0.14.x versions

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions