You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
HTTP/1 server: option to send trailers the client didn't ask for #4260
Since trailers were added to the HTTP/1 server, it has sent a response's trailers only when both of these hold:
the request had TE: trailers;
the response's Trailer header names them.
That's a reasonable default. A proxy, though, passes on whatever trailers its upstream sends. It can't know their names before they arrive, so it can't write a Trailer header, and clients often omit TE: trailers. Envoy's HTTP/1 codec, with enable_trailers, writes all of a chunked response's trailers regardless of either header.
Would you take a server option, http1::Builder::always_send_trailers(bool), default false? It would skip both checks. Fields that aren't allowed in trailers would still be dropped. I have a branch ready.
@GauravPawar101, i don't think that would be a good use of your time. this issue is blocked on discussion reaching consensus, rather than implementation. the original post notes that they already have a branch ready, should we decide to move forward with this proposal. thank you for offering, though!
Hm, after taking another look at trailers defined in RFC 9110, it seems the Trailer header is meant as a hint, not as an absolute. So, I don't even know if an option should be required, perhaps we just stop enforcing the hint. The hint is meant for the user code anyways. What do we think?
Activity
GauravPawar101 commentedon Nov 9, 2026
Hey, I would like to work on this
cratelyn commentedon Nov 9, 2026
@GauravPawar101, i don't think that would be a good use of your time. this issue is blocked on discussion reaching consensus, rather than implementation. the original post notes that they already have a branch ready, should we decide to move forward with this proposal. thank you for offering, though!
seanmonstar commentedon Nov 9, 2026
Hm, after taking another look at trailers defined in RFC 9110, it seems the
Trailerheader is meant as a hint, not as an absolute. So, I don't even know if an option should be required, perhaps we just stop enforcing the hint. The hint is meant for the user code anyways. What do we think?GauravPawar101 commentedon Nov 10, 2026
Thanks for the heads up