Skip to content

style(lib): enforce clippy::needless_pass_by_value - #4257

Open
trivikr wants to merge 2 commits into
hyperium:masterfrom
trivikr:clippy_needless_pass_by_value
Open

trivikr wants to merge 2 commits into
hyperium:masterfrom
trivikr:clippy_needless_pass_by_value

Conversation

@trivikr

@trivikr trivikr commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

see #4071.

Lint doc: https://clippy.rust-lang.org/master/index.html#needless_pass_by_value

The rule checks for functions taking arguments by value, but not
consuming them in its body. It replaces them to take arguments by
reference to avoid unnecessary allocations.

@cratelyn
cratelyn self-requested a review November 3, 2026 23:28
Comment thread src/proto/h2/mod.rs Resolved
@trivikr
trivikr requested a review from seanmonstar November 9, 2026 07:49
@trivikr
trivikr force-pushed the clippy_needless_pass_by_value branch from 7e33b19 to a9d668b Compare November 11, 2026 00:25
@trivikr

trivikr commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Does this look good to review/merge @seanmonstar / @cratelyn ?

@cratelyn
cratelyn removed their request for review November 16, 2026 17:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants