Repository navigation
Fix #4349: avoid folding user delegate initialization - #4354
Open
siegfriedpammer wants to merge 1 commit into
Open
siegfriedpammer wants to merge 1 commit into
siegfriedpammer wants to merge 1 commit into
Conversation
User fields with a null-checked delegate assignment are ordinary lazy initialization, not compiler caches. Require generated-field metadata before folding the VB cache patterns, while retaining coverage of the C# regression and VB compiler cache shapes. Assisted-by: OpenCode:gpt-6-luna:OpenCode
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4349.
Delegate-cache folding was matching a user-authored lazy delegate initialization and dropping its field access and null check. Require compiler-generated metadata on the cache field or its containing type before applying the VB cache patterns. Add a C# regression fixture and exercise VB delegate caches across the compiler matrix.
Validation:
dotnet test --project ICSharpCode.Decompiler.Tests/ICSharpCode.Decompiler.Tests.csproj --no-build --filter "FullyQualifiedName~PrettyTestRunner.Issue4349" --report-trx(18 passed)dotnet test --project ICSharpCode.Decompiler.Tests/ICSharpCode.Decompiler.Tests.csproj --no-build --filter "FullyQualifiedName~VBPrettyTestRunner.VBDelegateCache" --report-trx(20 passed)