Repository navigation
fix: ApiClient finalizer during interpreter shutdown - #720
karel-rehor merged 3 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #720 +/- ##
==========================================
- Coverage 90.46% 90.35% -0.11%
==========================================
Files 40 40
Lines 3555 3568 +13
==========================================
+ Hits 3216 3224 +8
- Misses 339 344 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Addressed the coverage advisory in 4bc8d34 with regression tests for signout failure, thread-pool close/join failures, and HTTP-pool cleanup failure. The tests verify later cleanup still runs and no teardown exception escapes. All executable lines in the changed finalizer (lines 86-106) are covered by the local coverage run. Validation: |
There was a problem hiding this comment.
@abhinavrastogi2627 Thank you for this contribution!
Looks good to me. 🚴 🏁
Summary
ApiClient.__del__from raising while Python clears client state during interpreter shutdownCloses #719
Validation
pytest -q tests/test_InfluxDBClientAuthorization.pyflake8 --isolated --max-line-length=120 --select=E501 influxdb_client/_sync/api_client.py tests/test_InfluxDBClientAuthorization.pygit diff --checkThe full
pytest -qcommand was attempted after installing the test, extra, and async dependencies. It requires an InfluxDB server atlocalhost:8086; collection proceeded, then the integration suite failed at its first server connection because no local server is available.