Repository navigation
Conversation
Allow callers to capture opcode counts without a temporary file. Keep the path overload and report on destruction, preserving decimal JSON output without modifying the supplied stream formatting.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstructionCounter currently requires a file path, so callers need a temporary file to capture its JSON report. Add an
std::ostream&overload, matching the other built-in tracer factories, while retaining the existing path overload and destructor-time output.Both destinations share the same serialization. Counts remain decimal JSON numbers even when the supplied stream uses hexadecimal formatting, without changing the caller's formatting flags. The supplied stream must outlive the tracer.
Tests cover deferred output, empty reports, aggregation across executions, hexadecimal stream flags, and VM destruction. The tracing fixture removes tracers before its output stream is destroyed.
Validation:
cmake --build build/debug --target evmone-unittests evmone-cli --parallel 6.ctest --test-dir build/debug --output-on-failure -R '/tracing\.|t8n/cancun_create_tx': all 28 tests passed, including the existing file-output integration test.clang-format --dry-run --Werroron the three changed files.CircleCI's
clang-latest-sanitizers,fuzzing, andclang-tidyrunner jobs were blocked before execution withoss-fork-on-runner("Forked prs not allowed to run on OSS projects").