Repository navigation
Conversation
Replace the (gas_left -= cost) < 0 idiom with gas_left.charge(cost), so that the gas check is defined in one place. charge() subtracts the cost and returns false when the gas left goes negative. It asserts that neither the gas left nor the cost is negative: the execution starts with non-negative gas and stops at the first failed charge.
This was referenced Oct 28, 2026
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## evm/gas-strong-type #1789 +/- ##
====================================================
Coverage 98.24% 98.24%
====================================================
Files 187 187
Lines 17188 17188
Branches 3921 3921
====================================================
Hits 16886 16886
Misses 233 233
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
(gas_left -= cost) < 0idiom withgas_left.charge(cost), so that the gas check is defined in one place.charge()asserts that neither the gas left nor the cost is negative: the execution starts with non-negative gas and stops at the first failed charge.The benchmarks execute the same number of instructions as with #1564, with both GCC 16 and Clang 21.
Stacked on #1564.