Repository navigation
Conversation
An exceptional halt consumes all gas, so the gas left is not needed when the stack or gas check fails. Returning it made Clang keep two copies of the gas counter, because a failed stack check returns the gas before the charge and a failed gas check returns it after.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## evm/gas-charge-wrap-clang #1791 +/- ##
==========================================================
Coverage 98.24% 98.24%
==========================================================
Files 187 187
Lines 17191 17192 +1
Branches 3921 3921
==========================================================
+ Hits 16889 16890 +1
Misses 233 233
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exceptional halt consumes all gas, so the gas left is not needed when the stack or gas check fails. Returning it made Clang keep two copies of the gas counter, because a failed stack check returns the gas before the charge and a failed gas check returns it after.
Clang 21 executes another 1% fewer instructions in the main benchmarks and 5% fewer in the micro ones (about 28% in the JUMPDEST ones). With GCC 16 this also removes the extra instructions added by #1564.
The whole series, over master: Clang 21 executes about 7% fewer instructions in the main benchmarks and 12% fewer in the micro ones, GCC 16 the same number. Cycles stay within the noise with both.
Stacked on #1790.