Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1804 +/- ##
=======================================
Coverage 98.23% 98.24%
=======================================
Files 186 186
Lines 17141 17162 +21
Branches 3949 3952 +3
=======================================
+ Hits 16839 16860 +21
Misses 233 233
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
chfast
force-pushed
the
crypto/ksi-mul9-fused
branch
from
November 4, 2026 19:04
d04f0cf to
a15f046
Compare
The multiplication by ksi computed 9a0 − a1 and 9a1 + a0 with a Montgomery multiplication by 9 followed by a modular subtraction or addition. Add modmuladd9(x, y, mod) computing (9x + y) % mod directly: the sum 9x + y is below 10·mod, so a quotient estimated from its top word is exact or one less, and one conditional subtraction completes the reduction. Multiplying by an integer keeps the Montgomery form, so it works on the internal representation as is. Field elements expose it as mul9_add(a, b) and mul9_sub(a, b). This reduces the ecpairing cycles by about 4.5% with GCC 15 and 5% with Clang 23.
chfast
force-pushed
the
crypto/ksi-mul9-fused
branch
from
November 5, 2026 06:03
a15f046 to
8b0cc64
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The new reduction lacks direct tests validating its generic modulus contract, including boundary moduli, extra-word carry, and quotient-estimate edge cases.
1 open issue
What changed in this PR
Optimizes BN254 pairing’s multiplication by ksi by replacing Montgomery multiplications by 9 and separate additions or subtractions with combined modular reductions.
Changes:
- Adds
modmuladd9to compute(9x + y) % moddirectly while preserving Montgomery form. - Exposes
mul9_addandmul9_subon field elements and uses them in the ksi product.
| File | Description |
|---|---|
lib/evmone_precompiles/pairing/bn254/fields.hpp |
Uses the combined operations for multiplication by ksi. |
lib/evmone_precompiles/modarith.hpp |
Adds quotient-estimation reduction for 9x + y. |
lib/evmone_precompiles/ecc.hpp |
Adds field-element wrappers for 9a + b and 9a - b. |
Review effort: Balanced
Comment on lines
+93
to
+95
| const auto s = UintT::num_bits - intx::clz(mod) - 64 + 4; | ||
| const auto d = static_cast<uint64_t>(mod >> s) + 1; | ||
| const auto q = static_cast<uint64_t>(t >> s) / d; |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The multiplication by ksi computed 9a0 − a1 and 9a1 + a0 with
a Montgomery multiplication by 9 followed by a modular subtraction or
addition.
Add modmuladd9(x, y, mod) computing (9x + y) % mod directly: the sum
9x + y is below 10·mod, so a quotient estimated from its top word is
exact or one less, and one conditional subtraction completes the
reduction. Multiplying by an integer keeps the Montgomery form, so it
works on the internal representation as is. Field elements expose it
as mul9_add(a, b) and mul9_sub(a, b).
This reduces the ecpairing cycles by about 4.5% with GCC 15 and 5% with
Clang 23.