Repository navigation
fix: update BlockSignatures with changes from spec - #20
Merged
Merged
Conversation
commit b153373806aa49f65aadc47c41b68ead4fab7d6e
MegaRedHand
marked this pull request as ready for review
January 13, 2026 16:07
pablodeymo
added a commit
that referenced
this pull request
Jul 24, 2026
PR #20 landed the spec-conformant transport on ethp2p-rs main (squash-merged as d852f23). Move the pin off the pre-merge branch commit (3d23411) to that main commit, which additionally brings in the hardening added after the Slice-7 bump: reconstruct-reset, per-peer bounded queues with backpressure, opt-in peer-id pinning, and — importantly — the fix for a load-dependent livelock where a backpressured chunk send spun drain_session without yielding. Pinning to a commit on main (rather than a branch that may be deleted) also gives the git dependency stable provenance. No adapter changes: the new transport APIs are additive, so bind/connect/Net::send/events are unchanged. The in-crate round-trip test and the default feature-off build both pass.
tcoratger
pushed a commit
to tcoratger/ethlambda
that referenced
this pull request
Oct 30, 2026
…class#20) A live beacon-follower profile shows one thread pinned at 100% of a core while the other 15 sit idle, with 12.5% of total cycles spent in is_valid_indexed_attestation, almost all of it in blst's mulx_mont routines: the per-key subgroup check inside aggregate_verify and fast_aggregate_verify. An Electra block can carry thousands of attesters behind one aggregate, and the state transition only ever runs on a single actor thread, so that loop was leaving a mostly-idle host's other cores untouched on every block import. Each key's validation is independent of every other key's, so nothing about the result depends on running them in order; rayon's par_iter spreads the checks across its pool and still collapses to false the moment any key fails, exactly like the sequential loop's early return did, without skipping or weakening key_validate for a single key. with_min_len keeps small inputs (a devnet or a spec fixture) on one thread instead of paying dispatch overhead for a handful of keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes were made to the
BlockSignaturestype recently