Repository navigation
Conversation
github-actions
Bot
added
the
size:XL
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-10-20 10:22:09.811977752 +0000
+++ /tmp/pyrefly_pr.txt 2026-10-20 10:22:00.963919502 +0000
@@ -4591,13 +4591,13 @@
ERROR Object of class `ModuleType` has no attribute `TraceTask` [missing-attribute]
--> tests/unit_tests/core/workflow/nodes/tool/test_tool_node_runtime.py:36:9
ERROR Object of class `object` has no attribute `parent_trace_context` [missing-attribute]
- --> tests/unit_tests/core/workflow/nodes/tool/test_tool_node_runtime.py:189:12
+ --> tests/unit_tests/core/workflow/nodes/tool/test_tool_node_runtime.py:227:12
ERROR Object of class `object` has no attribute `trace_session_id` [missing-attribute]
- --> tests/unit_tests/core/workflow/nodes/tool/test_tool_node_runtime.py:230:12
+ --> tests/unit_tests/core/workflow/nodes/tool/test_tool_node_runtime.py:268:12
ERROR Argument `object` is not assignable to parameter `message` with type `ToolInvokeMessage.BlobChunkMessage | ToolInvokeMessage.BlobMessage | ToolInvokeMessage.FileMessage | ToolInvokeMessage.JsonMessage | ToolInvokeMessage.LogMessage | ToolInvokeMessage.RetrieverResourceMessage | ToolInvokeMessage.TextMessage | ToolInvokeMessage.VariableMessage | None` in function `core.workflow.node_runtime.DifyToolNodeRuntime._convert_message_payload` [bad-argument-type]
- --> tests/unit_tests/core/workflow/nodes/tool/test_tool_node_runtime.py:320:48
+ --> tests/unit_tests/core/workflow/nodes/tool/test_tool_node_runtime.py:358:48
ERROR Argument `object` is not assignable to parameter `message` with type `ToolInvokeMessage.BlobChunkMessage | ToolInvokeMessage.BlobMessage | ToolInvokeMessage.FileMessage | ToolInvokeMessage.JsonMessage | ToolInvokeMessage.LogMessage | ToolInvokeMessage.RetrieverResourceMessage | ToolInvokeMessage.TextMessage | ToolInvokeMessage.VariableMessage | None` in function `core.workflow.node_runtime.DifyToolNodeRuntime._convert_message_payload` [bad-argument-type]
- --> tests/unit_tests/core/workflow/nodes/tool/test_tool_node_runtime.py:327:42
+ --> tests/unit_tests/core/workflow/nodes/tool/test_tool_node_runtime.py:365:42
ERROR Missing argument `name` in function `core.workflow.nodes.trigger_webhook.entities.WebhookParameter.__init__` [missing-argument]
--> tests/unit_tests/core/workflow/nodes/webhook/test_entities.py:54:25
ERROR Missing argument `name` in function `core.workflow.nodes.trigger_webhook.entities.WebhookBodyParameter.__init__` [missing-argument]
@@ -5439,11 +5439,11 @@
ERROR `dict[str, str]` is not assignable to dict value type `list[Unknown] | str` [bad-assignment]
--> tests/unit_tests/services/test_workflow_service.py:208:30
ERROR `dict[@_, @_]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-assignment]
- --> tests/unit_tests/services/test_workflow_service.py:3591:54
+ --> tests/unit_tests/services/test_workflow_service.py:3726:54
ERROR Argument `Literal['invalid']` is not assignable to parameter `value` with type `AppMode | SQLCoreOperations[AppMode]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
- --> tests/unit_tests/services/test_workflow_service.py:3637:20
+ --> tests/unit_tests/services/test_workflow_service.py:3772:20
ERROR Argument `dict[str, str | dict[str, str]]` is not assignable to parameter `node_config` with type `NodeConfigDict` in function `services.workflow_service.WorkflowService._build_human_input_node_for_debugging` [bad-argument-type]
- --> tests/unit_tests/services/test_workflow_service.py:3668:65
+ --> tests/unit_tests/services/test_workflow_service.py:3803:65
ERROR Object of class `MCPToolProvider` has no attribute `provider_icon` [missing-attribute]
--> tests/unit_tests/services/tools/test_mcp_tools_transform.py:71:5
ERROR Object of class `MCPToolProvider` has no attribute `masked_server_url` [missing-attribute]
|
Contributor
Pyrefly Type Coverage
|
linw1995
marked this pull request as ready for review
October 20, 2026 07:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Tool Node credential configuration for SNP-964, including multiple enabled authentication methods, end-user descriptions, and test references. Authentication requirements are independent per node, including nodes from the same provider. Reuse from Node explicitly references directly configured Workspace or EndUser authentication on the same plugin, provider, and tool.
Preserve unfinished drafts, validate complete configurations through graph checks, and strip test references from ordinary DSL exports. Runtime resolution follows in SNP-965; until then, reject EndUser and reuse execution to prevent workspace credential fallback.