Skip to content

test(web): exercise workflow controls and access points through real owners - #44423

Merged
hyoban merged 3 commits into
mainfrom
test/web-cleanup-20261020-1705
Oct 21, 2026
Merged

hyoban merged 3 commits into
mainfrom
test/web-cleanup-20261020-1705

Conversation

@hyoban

@hyoban hyoban commented Oct 20, 2026

Copy link
Copy Markdown
Member

Replace owner-hook spies, a fake ReactFlow viewport, copied resize mutation logic, and access-point card render spies in six existing specs. The tests now exercise real canvas/store updates and real card DOM: menu clicks and shortcuts change graphs, edge insertion preserves handle routing, resize persists dimensions, zoom updates the viewport, and access points expose their availability and management permissions.

Reuse the shared workflow environment and node catalog. Consolidate redundant cases and remove the implementation-only retry-callback test; no production changes or coverage backfill.

Validation: 47 focused tests pass; targeted vp check and root vp run -w check pass. Mutation checks cover menu clicks, edge routing, persisted resize dimensions, zoom, and access-point availability/permissions; all mutations are detected and production sources restored.

@github-actions github-actions Bot added web This relates to changes on the web. size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.80%. Comparing base (688005d) to head (7707545).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #44423      +/-   ##
==========================================
+ Coverage   88.78%   88.80%   +0.02%     
==========================================
  Files        5553     5553              
  Lines      332846   332847       +1     
  Branches    66595    66594       -1     
==========================================
+ Hits       295508   295576      +68     
+ Misses      32156    32089      -67     
  Partials     5182     5182              
Flag Coverage Δ
dify-ui 91.67% <ø> (ø)
web 88.46% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hyoban
hyoban marked this pull request as ready for review October 21, 2026 05:09
@hyoban
hyoban requested review from iamjoel and zxhlyh as code owners October 21, 2026 05:09
@hyoban
hyoban added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit 1944043 Oct 21, 2026
49 checks passed
@hyoban
hyoban deleted the test/web-cleanup-20261020-1705 branch October 21, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants