Repository navigation
test(web): exercise workflow controls and access points through real owners - #44423
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44423 +/- ##
==========================================
+ Coverage 88.78% 88.80% +0.02%
==========================================
Files 5553 5553
Lines 332846 332847 +1
Branches 66595 66594 -1
==========================================
+ Hits 295508 295576 +68
+ Misses 32156 32089 -67
Partials 5182 5182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hyoban
marked this pull request as ready for review
October 21, 2026 05:09
lyzno1
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace owner-hook spies, a fake ReactFlow viewport, copied resize mutation logic, and access-point card render spies in six existing specs. The tests now exercise real canvas/store updates and real card DOM: menu clicks and shortcuts change graphs, edge insertion preserves handle routing, resize persists dimensions, zoom updates the viewport, and access points expose their availability and management permissions.
Reuse the shared workflow environment and node catalog. Consolidate redundant cases and remove the implementation-only retry-callback test; no production changes or coverage backfill.
Validation: 47 focused tests pass; targeted
vp checkand rootvp run -w checkpass. Mutation checks cover menu clicks, edge routing, persisted resize dimensions, zoom, and access-point availability/permissions; all mutations are detected and production sources restored.