Repository navigation
fix(http): accept a bare ipv6 host joined with a port - #351
Closed
tzssangglass wants to merge 1 commit into
Closed
tzssangglass wants to merge 1 commit into
tzssangglass wants to merge 1 commit into
Conversation
A caller that builds "scheme://" .. host .. ":" .. port with a bare IPv6 host produces "http://::1:8080", which no URI grammar can parse: the colons are ambiguous. Tolerate it in parse_uri by splitting at the last colon only when the part before it already looks like an IPv6 address (two or more colons), then bracket that part. Names, IPv4 addresses and hosts that already carry brackets are left untouched, and a portless bare literal is still rejected rather than guessed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A caller that builds "scheme://" .. host .. ":" .. port with a bare IPv6 host produces "http://::1:8080", which no URI grammar can parse: the colons are ambiguous. Tolerate it in parse_uri by splitting at the last colon only when the part before it already looks like an IPv6 address (two or more colons), then bracket that part.
Names, IPv4 addresses and hosts that already carry brackets are left untouched, and a portless bare literal is still rejected rather than guessed.