Skip to content

fix(widget): reject superseded and expired quotes - #927

Open
o-mid wants to merge 4 commits into
lifinance:mainfrom
o-mid:test/quote-expiry-useRoutes
Open

o-mid wants to merge 4 commits into
lifinance:mainfrom
o-mid:test/quote-expiry-useRoutes

Conversation

@o-mid

@o-mid o-mid commented Nov 8, 2026 •

Copy link
Copy Markdown

A cancelled quote fetch no longer emits availableRoutes or writes token prices, and review will not hand an idle quote to execution once it is past the 60s window. Quotes older than that window are fetched immediately.

Fixes #926. The tests check a cancelled response, an amount change, an overdue quote, and the review handoff.

Checkout still freezes quotes on its own 30 minute timer and does not pass a fetch time into this check.

@changeset-bot

changeset-bot Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9792a8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@lifi/widget Patch
@lifi/widget-checkout Patch
connectkit Patch
deposit-flow Patch
dynamic Patch
nextjs Patch
nextjs15 Patch
nft-checkout Patch
nuxt-app Patch
privy-ethers-example Patch
privy Patch
rainbowkit Patch
react-router Patch
remix Patch
reown Patch
svelte Patch
tanstack-router-example Patch
vite-project Patch
vue Patch
zustand-widget-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

A cancelled fetch no longer publishes routes or token prices.
An idle quote past the refresh window is not signed.
Quotes older than the window refetch immediately.
@o-mid o-mid changed the title test: cover quote refresh and expiry in useRoutes fix(widget): reject superseded and expired quotes Nov 8, 2026
@o-mid

o-mid commented Nov 12, 2026

Copy link
Copy Markdown
Author

@chybisov superseded and expired quotes are rejected. Open since Sunday with no review. Could you take a look?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancelled quote fetches still publish, and expired quotes can still be executed

1 participant