Repository navigation
Conversation
A fixed header with a top offset was padded by its height only. The form sat underneath it. Full height now keeps that offset in step with the mock header.
|
Author
|
@chybisov content below a shifted fixed header is cleared. Open since Nov 9, no review yet. Could you look? |
…d-header-clearance
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fixed widget header with a top offset was padded by its own height only, so the form started underneath it. The scroll padding now includes that offset, and full height in the playground keeps the offset equal to the mock header, including after the mock header is toggled on.
The developer-control tests for that overlap now check the padded content, not the scroll box edge. The theme-switch height test is no longer marked failing, because setConfigTheme already keeps the container height.