Repository navigation
feat: move oidc settings under otomi - #1099
Draft
CasLubbers wants to merge 27 commits into
Draft
CasLubbers wants to merge 27 commits into
CasLubbers wants to merge 27 commits into
Conversation
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
This reverts commit 89de000.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
CasLubbers
requested review from
dennisvankekem and
ferruhcihan
as code owners
October 1, 2026 11:20
CasLubbers
marked this pull request as draft
October 1, 2026 11:20
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Existing OIDC data lacks a migration path, and required-field validation was dropped.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Moves OIDC configuration under platform (otomi) settings.
Changes:
- Relocates OIDC schema fields under
otomi.oidc. - Removes the standalone identity-provider resource mapping.
- Updates the package-lock package name.
| File | Description |
|---|---|
src/otomi-models.ts |
Updates OIDC typing and removes its resource kind. |
src/openapi/settings.yaml |
Nests OIDC configuration under platform settings. |
src/fileStore/file-map.ts |
Removes standalone OIDC file mapping. |
package-lock.json |
Aligns the package name with package.json. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - keycloak | ||
| default: keycloak | ||
| description: Which app every consumer authenticates against. | ||
| issuer: |
| description: OIDC scopes requested from the external identity provider. (Dex only) | ||
| items: | ||
| type: string | ||
| default: [openid, profile, email, groups] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.