[lbarrosby]

service.beta.kubernetes.io/linode-loadbalancer-tags is split on commas without trimming, so a value written like the other list annotations, "production, web-tier", sends " web-tier" (leading space) to the NodeBalancer API, and a trailing or doubled comma ("production,,web-tier,") sends an empty tag. The same list is compared with reflect.DeepEqual against nb.Tags in updateNodeBalancer, so the values stored by the API and the desired list can disagree on every sync.

GetLoadBalancerTags now trims each entry and skips empty ones. Values that were already clean ("fake,test,yolo") produce the same list as before.

Tests: added Test_loadbalancers_GetLoadBalancerTags (no annotation, plain list, spaces after commas, empty entries, empty annotation). The last three fail on master and pass with the change. go test ./cloud/... and golangci-lint run -c .golangci.yml ./cloud/linode/ are clean.

General:

• Have you removed all sensitive information, including but not limited to access keys and passwords?
• Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

1. Does your submission pass tests?
2. Have you added tests?
3. Are you addressing a single feature in this PR?
4. Are your commits atomic, addressing one change per commit?
5. Are you following the conventions of the language?
6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
7. Have you explained your rationale for why this feature is needed?
8. Have you linked your PR to an open issue

[komer3]

Thanks for contribution :)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.65%. Comparing base (1143441) to head (69cf572).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   82.64%   82.65%   +0.01%     
==========================================
  Files          19       19              
  Lines        2616     2618       +2     
==========================================
+ Hits         2162     2164       +2     
  Misses        454      454              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.