Repository navigation
Conversation
Contributor
Author
|
Demo with a fixture run, because the server does not fill these fields yet: CI output marks the two failures that were already red (header, historically-red.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
lk agent simulatereports a failed scenario, the output looks the same whether the change under test broke it or the scenario was already failing in earlier runs of the same agent. Coding agents that read this output (CI logs, the TUI report file) then spend their time chasing failures that predate their change.Change
The server now marks each job with its scenario's recent history (
SimulationRun_Job.prior_passed,SimulationRun_Job.historically_red; see the protocol PR below). The CLI only reads the server'shistorically_redflag. It does not recompute the threshold. The marker is shown only for failed scenarios that the server flags as historically red:::group::header and its::error::line get a suffix:prior_passed, and M is its length.historically redtag on the failed row in the scenario list, and in the scenario and job detail headers.--exportJSON: protojson already includesprior_passedandhistorically_red, so no code change was needed.The first commit is a pure refactor. It splits the per-scenario verdict out of
scenarioFailureCountsso the report can check whether a single scenario failed.Dependencies
go.modpoints at that branch's pseudo-version until it merges.