Repository navigation
fix(lk): rename workspace projects through ProjectService - #1071
Merged
Topherhindman merged 1 commit intoOct 23, 2026
Merged
Topherhindman merged 1 commit into
Topherhindman merged 1 commit into
Conversation
The Public API is dropping WorkspaceService.UpdateProject (livekit/public-api-server#98). It duplicated ProjectService.UpdateProject, and its PATCH path collided with the workspace GetProject/DeleteProject path in the OpenAPI spec. `lk workspace project update` keeps its interface. UpdateWorkspaceProject now reads the project through the workspace first, so a project outside --workspace still answers 404, and then renames it with ProjectService.UpdateProject. This works against the server before and after #98, and the next client regen no longer needs WorkspaceServiceUpdateProject.
JackNDwyer
approved these changes
Oct 23, 2026
Topherhindman
deleted the
topherhindman/devx-861-lk-workspace-project-update-keeps-working-after
branch
October 23, 2026 16:22
Topherhindman
added a commit
that referenced
this pull request
Oct 23, 2026
Picks up livekit/public-api-server#98, which makes the spec a client contract. Every operation now declares its error response, a google.rpc.Status, so each generated response gains a JSONDefault *GoogleRpcStatus, and GoogleRpcStatus and GoogleProtobufAny are new types. Nothing hand-written reads them yet. #98 also deletes WorkspaceService.UpdateProject, so its client methods and types are gone. lk workspace project update no longer calls it (#1071). Also picks up the server's proto comment cleanup, which roughly halves the doc comments, and the oneOf helpers of a few protocol messages (AutoTrackEgress, the egress outputs, chat and transcript items, metric points) losing their empty last variant. Nothing hand-written uses those either. Generated from livekit/public-api-server@4cfd5cf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DEVX-861
Why
livekit/public-api-server#98 deletes
WorkspaceService.UpdateProject. It duplicatedProjectService.UpdateProject, and its PATCH route differed from the workspace Get/Delete route only by parameter name, which made the OpenAPI spec invalid.lk workspace project updateis its only caller. Since #1070 the command shows for signed-in users, so it would fail once livekit/public-api-server#98 deploys, and the next client regen would stop compiling.What changed
UpdateWorkspaceProject(pkg/public/workspaces.go) keeps its signature. It now:GET /v0/workspaces/{ws}/projects/{id}, so a project outside--workspacestill returns 404, as the old route didPATCH /v0/projects/{id}, the same calllk project updatemakesThe command's name, flags and output don't change. Both routes exist on the server today, so this can merge before or after livekit/public-api-server#98.
Testing
go test ./pkg/public/...: newworkspaces_test.gochecks the GET → PATCH order and body, and that a 404 on the GET stops before the PATCH.oapi.gen.gorefers toWorkspaceServiceUpdateProjectanymore.