Repository navigation
fix(color): normalize scheme seeds without # to #RRGGBB - #459
Merged
Merged
Conversation
hexToRgb already accepts "ff00aa", but schemeFromSeed stored the uppercased raw string as seed, so the palette carried "FF00AA" instead of "#FF00AA". Write the canonical #RRGGBB when the seed parses.
Owner
|
Thanks, merged. The app itself always passes a seed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hexToRgbalready accepts a 6-digit seed without a leading#("ff00aa").schemeFromSeedstill storedseedHex.toUpperCase()aspalette.seed, so that input became"FF00AA"instead of the canonical"#FF00AA"used everywhere else (and required byisHex).When the seed parses, set
seedfromrgbToHexso it is always#RRGGBB. Invalid seeds are still uppercased as before.Test plan
npx vitest run lib/color.extended.test.ts lib/color.test.tsschemeFromSeed("ff00aa").seed === "#FF00AA"(fails before, passes after)npm run typecheckSummary by cubic
Fixes
schemeFromSeedso valid seeds without#are stored as#RRGGBBinpalette.seed, matching the canonical format used elsewhere and required byisHex. PreviouslyschemeFromSeed("ff00aa").seedreturned"FF00AA".Written for commit 36f1e6d. Summary will update on new commits.