Repository navigation
[10004] fix: translated aria labels for sidebar toggles - #10005
Open
Vishesh-Verma-07 wants to merge 1 commit into
Open
Vishesh-Verma-07 wants to merge 1 commit into
Vishesh-Verma-07 wants to merge 1 commit into
Conversation
The "More"/extended-sidebar toggles referenced `aria_labels.app_sidebar.*`, a namespace no locale file defines. i18next therefore fell back to the key, so screen readers announced the raw string instead of a label. Point the toggles at `aria_labels.projects_sidebar.open_extended_sidebar` / `close_extended_sidebar`, which already exist with translations in every locale. Fixes makeplane#10004
|
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the fix: translated ARIA labels for sidebar toggles. It is concise and directly related to the changes. |
| Description check | |
The description explains the cause, affected toggles, exact translation-key changes, bug-fix type, manual test scenarios, and issue reference. It satisfies the repository template; screenshots are not… |
| Linked Issues check | |
Issue #10004 requires removal of undefined aria_labels.app_sidebar.* labels from the sidebar toggles. The reviewed code changes both #extended-sidebar-toggle in sidebar-menu-items.tsx and `#exte… |
| Out of Scope Changes check | |
The reviewed changes are limited to the two sidebar toggle aria-label translation-key selections described by issue #10004. The toggle behavior and visible text remain unchanged. No unrelated source… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The sidebar "More"/extended-sidebar toggles set their
aria-labelfromaria_labels.app_sidebar.*, but no locale file defines that namespace (packages/i18n/src/locales/*/accessibility.jsononly definesaria_labels.projects_sidebar,auth_forms,breadcrumb,commonandcolor_picker). i18next falls back to the key, so the raw string is used as the accessible name.This affects two buttons:
#extended-sidebar-toggle) insidebar-menu-items.tsx#extended-project-sidebar-toggle) inprojects-list.tsxBoth now reference
aria_labels.projects_sidebar.open_extended_sidebar/close_extended_sidebar, which already exist with translations in all locales. No new translation keys are introduced.Type of Change
Screenshots and Media (if applicable)
Test Scenarios
[...document.querySelectorAll('[aria-label]')].map(e => e.getAttribute('aria-label')).filter(v => v.startsWith('aria_labels.'))aria_labels.app_sidebar.close_extended_sidebar/open_extended_sidebar).References
apps/web/components/...after the webcore/flatten ([GIT-351] chore: flatten web components out of core/ #9883); the branch is based onpreviewatbab49bb978, the commit the issue measured.🤖 Generated with OpenCode
Summary by CodeRabbit