Automatically push context parameters into endpoints when safe #463

Activity

1. ikitommi commented on Apr 23, 2024

   

   ikitommi

   on Apr 23, 2024

   Member

   More actions

   Great idea!
2. frenchy64 commented on Apr 29, 2024

   

   frenchy64

   on Apr 29, 2024

   CollaboratorAuthor

   More actions

   If a context would be inferred as dynamic, we can push the context into each body form. Then we can proceed to handle individual cases, but the advantage is it automatically handles hybrid static/dynamic contexts. The inner contexts that are static will be inferred as static, ditto dynamic.

     (let [f (fn [] (GET "/bar" [] "body just for doc and coercion"))]
       (context "/foo" []
                :body [body s/Str]
                (GET "/bar" [] body)
                (f)))
     =>
     (let [f (fn [] (GET "/bar" [] "body just for doc and coercion"))]
       (vector
         (context "/foo" []
                  :body [body s/Str]
                  (GET "/bar" [] body))
         (context "/foo" []
                  :body [body s/Str]
                  (f))))
     =>
     (let [f (fn [] (GET "/bar" [] "body just for doc and coercion"))]
       (vector
         (context "/foo" []
                  (GET "/bar" []
                       :body [body s/Str]
                       body))
         (context "/foo" []
                  (-> (f)
                      (update :handler (let [g (partial coercion/coerce-request! s/Str :body-params :body true false)]
                                         #(comp % g)))
                      (update-in [:info :public :parameters :body] #(or % s/Str))))))
3. frenchy64 commented on Apr 29, 2024

   

   frenchy64

   on Apr 29, 2024

   Last edited by frenchy64

   CollaboratorAuthor

   More actions

   Another insight is that if all :lets and :letks bindings are never used in the body, we can treat it like a static context. This is because the bindings are just side effects, and as long as we update the handler with the side effect and any :info needed, it's equivalent.

   This is a useful observation if the context body calls a function. If the function doesn't get passed the body, then we can just update the route after it's been evaluated.

   (let [f (fn [] (GET "/bar" [] "body just for doc and coercion"))]
     (context "/foo" []
              :body [body s/Str]
              (f)))
   =>
   (let [f (fn [] (GET "/bar" [] "body just for doc and coercion"))]
     (context "/foo" []
              (-> (f)
                  ...for each route...
                  (update :handler (let [g (partial coercion/coerce-request! s/Str :body-params :body true false)]
                                     #(comp % g)))
                  (update-in [:info :public :parameters :body] #(or % s/Str)))))