Repository navigation
Fix XAML IntelliSense build contention and project-state bugs - #371
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
VSIX Build
Updated 2026-11-07 00:31:32 UTC · commit |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
PR Review — chiaramooney-xaml-intellisense-fixes vs mainDecisionChanges required. One bug I reproduced: a project folder with one unreadable subfolder now loses XAML IntelliSense entirely. Must fixThe new project-input walk crashes on an unreadable or vanishing folder
Non-blockingNone. What was exercised
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Jaylyn Barbee (@Jaylyn-Barbee) Fixed in 6f4e4d6. The input scan now catches only IOException and UnauthorizedAccessException when listing directories, checking child attributes, or reading file stamps. It logs the affected path and continues scanning readable siblings instead of failing project load or refresh. Added Windows ACL regressions covering a subfolder denied before snapshot construction and after construction before HasChanges. Both reproduced the exception before the fix and now pass, while edits in a readable sibling are still detected. Added coverage for a removed project directory with surviving inputs as well. Validation: the full workspace suite passed (266 tests), and |
Description
Fix five XAML IntelliSense reliability issues:
Usage Example
With two buttons named
FirstandSecond, renamingFirsttoSecondorclassis rejected before any edits are applied. A valid Unicode identifier remains accepted. Saving a new C# reference and immediately renaming its XAML element refuses safely while the project refreshes, then checks the updated code-behind.When two applications share a library, opening their XAML pages does not overwrite that library's normal build outputs. Hover and navigation remain available during project refreshes. An ordinary XAML save does not restart the project build.
Changing a package version in
Directory.Packages.propswithout restoring reports restore-required on XAML save. Matching restored assets recover the project context.Related Issue
Fixes #345
Fixes #346
Fixes #348
Fixes #349
Fixes #350
Type of Change
Checklist
.\scripts\build-vsce.ps1locallydocs/XAML-AOT.md.package.jsoncontribution points / command/debugger/custom-editor docs updated (if extension surface changed): N/A.Screenshots / Demo
Nonvisual changes. Regressions exercise real WinUI markup generation, concurrent applications sharing a library, locked user-build output, malformed markup and recovery, rename during refresh, missed watcher events, and central package restore freshness.
Additional Notes
Local Windows validation:
npm run compile-tscnpm run lintnpm run test:unitnpm run sync-schemas; extension sources are unchanged by the follow-up fixes.npm run test:server --silentnpm run test:xaml-smoke --silent.\scripts\build-vsce.ps1 -Package$env:WINUI_XAML_SERVER_BUNDLE_MODE='source'; npm exec --no -- vsce package --out artifacts\winapp-xaml-followup.vsix --pre-release$env:WINUI_XAML_SERVER_BUNDLE_MODE='artifact'; npm run test:xaml-bundled --silentThe installed final VSIX was driven through the isolated VS Code harness. An unused name remained renameable; after saving a new C# reference, rename refused promptly during a deliberately paused refresh while typed hover remained available. Once refresh completed, the code-behind safety check rejected the rename.
ARM64 was packaged but not executed on this x64 machine. Existing documented Roslyn trim warnings remain visible.
NuGet.Versioningprovides canonical version-range comparisons rather than a custom approximation.AI Description
This section is auto-generated by AI when the PR is opened or updated. To opt out, delete this entire section including the marker comments.