Repository navigation
openvmm: pin the WHP fix for nested UEFI timer interrupts - #384
Merged
Pedro Henrique Penna (ppenna) merged 1 commit intoOct 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The upstream dependency remains draft and unmerged, and exact-head NVX CI validation is still pending.
Review effort: Balanced
Findings: None
What changed in this PR
Updates NVX’s OpenVMM pin to mitigate the intermittent WHP UEFI timer-interrupt stack overflow tracked in #368.
Changes:
- Advances the
openvmmgitlink from974f35652to011f534a6. - Incorporates native handling of CPUID leaves 0 and 1 for eligible WHP partitions, without changing NVX microVM behavior.
| File | Description |
|---|
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pedro Henrique Penna (ppenna)
marked this pull request as ready for review
October 5, 2026 16:19
Pedro Henrique Penna (ppenna)
force-pushed
the
agents/fix-issue-368-baremetal-validation
branch
from
October 5, 2026 22:12
1b3a67c to
5d884f9
Compare
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: None
Pedro Henrique Penna (ppenna)
force-pushed
the
agents/fix-issue-368-baremetal-validation
branch
from
October 6, 2026 18:03
5d884f9 to
8ed4726
Compare
3e1f5bd48 lets WHP answer CPUID leaves 0 and 1 without exits for VTL0 partitions with the Hyper-V guest interface and no VTL2, nested virtualization, isolation, or time ABI. It programs the bits that OpenVMM's CPUID table sets in those leaves with CpuidResultList2, exits only on a 39-entry CPUID exit list, and fails partition creation if WHP's results differ from the table, so the guest-visible CPUID is unchanged. The mu_msvm UEFI firmware runs five CPUID instructions for those leaves on each SynIC timer EOI, with interrupts disabled, and enables interrupts again before its handler returns. Each of them used to exit to OpenVMM and wait on host scheduling, so under host contention a timer interrupt could outlast the firmware's 10 ms period, and the next one nested on the same stack until the DXE stack overflowed and the VM triple faulted. That is the intermittent failure of openvmm_uefi_x64_windows_datacenter_core_2022_x64_pcie_nvme_boot on Windows/WHP in #368. NVX microVMs use the time ABI and keep their CPUID configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 226731e8-3e38-4396-8109-80c7ab5f79bd
Pedro Henrique Penna (ppenna)
force-pushed
the
agents/fix-issue-368-baremetal-validation
branch
from
October 7, 2026 15:19
8ed4726 to
ba5bc7f
Compare
This was referenced Oct 7, 2026
Pedro Henrique Penna (ppenna)
deleted the
agents/fix-issue-368-baremetal-validation
branch
October 8, 2026 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin OpenVMM
51b0a79bdfrom nanvix/openvmm#109, which lets WHP answer CPUID leaves 0 and 1 without exits. On a busy Windows/WHP host, the UEFI firmware's timer interrupts then no longer nest until its DXE stack overflows and the VM triple faults.Fixes #368
Problem
multiarch::pcie::openvmm_uefi_x64_windows_datacenter_core_2022_x64_pcie_nvme_bootfailed in 1 of 62 runs ofOpenVMM vmm-tests / Windows / WHPwith a stack guard page fault in the mu_msvm v26.0.36 firmware'sEfiHvDxe, followed by a triple fault.The firmware's SynIC timer handler sends its EOI with interrupts disabled, and on each EOI, EDK2's local APIC library runs five
CPUIDinstructions for leaves 0 and 1.RestoreTPL()then enables interrupts before the handler returns, so a tick that outlasts the 10 ms timer period lets the next one nest on the same stack. OpenVMM's standard WHP partitions exit to OpenVMM on everyCPUID, so under host contention (about 20 VMs were booting in the failing run), each of thoseCPUIDs waited on host scheduling. nanvix/openvmm#109 has the full analysis.Change
The only change is the
openvmmgitlink, from07850d27ato51b0a79bd. That is one commit on nanvix/openvmmmainat07850d27a, the commit NVX already pins. It:--hv) and the in-hypervisor APIC;VTL2, nested virtualization, isolation, the user-mode APIC, and the time ABI keep their current behavior. NVX microVMs reject
--hv, so they are unaffected.Dependencies
51b0a79bdpreserved before this PR merges.Validation
Before the rebase below, on a bare-metal Windows Server 2025 WHP host (HPE DL380 Gen10, 2× Xeon Silver 4114), with NVX at
a3d929a. The OpenVMM source tree that was built is byte-for-byte identical to011f534a6's (tree292f61c49).python scripts\nvx.py test-openvmm --backend whpThe first three rows add a temporary diagnostic patch for the delays and counters. An earlier revision of the OpenVMM commit, which differed only in exiting on the whole 0x40000000–0x400000FF range, also passed the suite 29/29 in 6 more runs.
Rebase onto
devat03103c13nanvix/openvmm#109 moved from
cb18433adonb7696e7bato51b0a79bdon nanvix/openvmmmainat07850d27a, whichdevpins, and this PR's commit moved ontodevat03103c13. The only textual conflict was the gitlink. OpenVMM had one semantic conflict:d290df675madetopology_cpuidadd AMD's cache topology leaf, 0x8000001D, to the CPUID table, andverifyrejects a table leaf that neither exits nor is leaf 0 or 1, so on AMD hosts--hvpartitions would have failed to start withNativeCpuidUnrouted(0x8000001d). The exit list now includes 0x8000001D (39 entries).git range-diff b7696e7ba..cb18433ad 07850d27a..51b0a79bdshows no other change to the patch.At
51b0a79bd, on an AMD EPYC 7763 Hyper-V VM with WHP, with Rust 1.95.0:cargo test -p virt_whppasses (45 passed, and its new AMD case fails without the fix), as do the ignored real-WHP testwhp_answers_the_programmed_leaves,cargo clippy --all-targets -p virt_whp,cargo doc --no-deps -p virt_whp, andcargo xtask fmt --fix. On the same host, a debugopenvmm --hv --uefi firmware=MSVM.fd,disable_frontpagewith no boot device failed with "failed to create the partition: CPUID leaf 0x8000001d has a programmed result but does not exit" without the new exit-list entry, and with it booted through BDS and powered off. The previous NVX CI run's WHP vmm-test runner was an Intel Xeon Platinum 8370C, so CI may not exercise this path.python scripts\nvx.py verifypasses at8ed47267. The OpenVMM package checks are also listed in nanvix/openvmm#109.Not run locally: Linux/KVM and Linux/MSHV, since the change is WHP-only; the NVX CI matrix covers them. Head:
8ed47267363f45799bf9d58337c85bb9200c728e.Notes
NestedInterruptTplLib.