Repository navigation
fix(dnnl): Remove unused zero-point size calculation - #34196
Open
Airat Makhmutov (rautyrauty) wants to merge 1 commit into
Open
Airat Makhmutov (rautyrauty) wants to merge 1 commit into
Airat Makhmutov (rautyrauty) wants to merge 1 commit into
Conversation
GCC 16 rejects the unused accumulator under -Werror. Fixes: 11f0a0a ("Convert graph initializers into OrtValue Phase I (microsoft#23979)")
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change removing the unused zero-point size calculation.
No open issues 🎉
What changed in this PR
Removes an unused zero-point element-count calculation from the oneDNN graph transformer to address GCC 16 builds failing under -Werror.
Changes:
- Deletes the unused dimension variables and accumulator loop in
RemoveMatMulIntegerZP, leaving the zero-point validation unchanged.
No actionable findings.
| File | Description |
|---|---|
onnxruntime/core/providers/dnnl/subgraph/dnnl_subgraph_transformer.cc |
Removes the unused zero-point size calculation. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 16 rejects the unused accumulator under -Werror.
Fixes: 11f0a0a ("Convert graph initializers into OrtValue Phase I (#23979)")