Repository navigation
feat: toHaveURLPattern - #38925
feat: toHaveURLPattern#38925
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| const url = parseURL(urlString); | ||
| if (!url) | ||
| return false; | ||
| if (isURLPattern(match)) |
There was a problem hiding this comment.
Can we also update protocol to support url patterns on the server side? See RouteHandler.prepareInterceptionPatterns for the reference.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| private _initScripts: InitScript[] = []; | ||
| private _requestInterceptor: RouteHandler; | ||
| private _interceptionUrlMatchers: (string | RegExp)[] = []; | ||
| private _interceptionUrlMatchers: (string | RegExp | URLPattern | undefined)[] = []; |
There was a problem hiding this comment.
Perhaps just URLMatch[]?
| private _clockPaused = false; | ||
| private _requestInterceptor: RouteHandler; | ||
| private _interceptionUrlMatchers: (string | RegExp)[] = []; | ||
| private _interceptionUrlMatchers: (string | RegExp | URLPattern | undefined)[] = []; |
There was a problem hiding this comment.
Perhaps just URLMatch[]?
| // eslint-disable-next-line no-restricted-globals | ||
| export const isURLPattern = (v: unknown): v is URLPattern => typeof globalThis.URLPattern === 'function' && v instanceof globalThis.URLPattern; | ||
|
|
||
| export function serializeURLPattern(v: URLPattern) { |
There was a problem hiding this comment.
Let's instead export serializeURLMatch() and handle all cases right here.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"5 failed 5 flaky34237 passed, 668 skipped Merge workflow run. |
Test results for "MCP"5 failed 3597 passed, 129 skipped Merge workflow run. |
Closes #38666