Repository navigation
fix(mcp): preserve all-interface HTTP hosts - #42953
Closed
Bennett Payoyo (Yahiro025) wants to merge 1 commit into
Closed
Bennett Payoyo (Yahiro025) wants to merge 1 commit into
Bennett Payoyo (Yahiro025) wants to merge 1 commit into
Conversation
Only normalize true loopback addresses in MCP HTTP URLs. Fixes: microsoft#42952
Author
|
@microsoft-github-policy-service agree |
Collaborator
|
Closing in favor of #42993. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
addressToString(..., { normalizeLoopback: true })was rewriting bind hosts0.0.0.0and[::]tolocalhost. That breaks MCP HTTP mode when started with--host 0.0.0.0(including the documented Docker setup), because the advertised URL / allowed host becomes loopback-only.Only true loopbacks (
127.0.0.1,[::1]) are normalized tolocalhostnow. Adds regression coverage intests/mcp/http.spec.ts.Fixes #42952