Repository navigation
test: pin module semantics of transpiled code - #43293
Pavel Feldman (pavelfeldman) merged 2 commits into
Conversation
| import { run } from './greeter'; | ||
|
|
||
| test('works', () => { | ||
| (util as any).greet = () => 'stub'; |
There was a problem hiding this comment.
I am not sure we want to support that. IIUC, this is impossible with ESM anyway.
There was a problem hiding this comment.
All these will fail when moving to esbuild, but we need to be mindful about it.
This comment has been minimized.
This comment has been minimized.
|
Hi, Playwright bot here — I reviewed the CI failures on head 🔴 The failure is caused by this PRThe newly added DetailsThis is the only real failure in the merged test report. The eight other entries are flaky tests that passed on retry, so they do not affect the verdict. Caused by this PR
Triaged by the Playwright bot - agent run |
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"5 flaky53316 passed, 1266 skipped Merge workflow run. |
Test results for "MCP"1 failed 9164 passed, 1495 skipped Merge workflow run. |
|
Hi, Playwright bot here — I reviewed the latest CI reports for PR head 🟢 The failure is a confirmed pre-existing flakeThe only real failure in the latest reports is unrelated to this PR's transpiler tests. The same MCP test failed with the same assertion on an unrelated change. DetailsThis PR changes only Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
Summary
.tsxandimport.metain CommonJS, so a transpiler change shows these differences.